-
-
Notifications
You must be signed in to change notification settings - Fork 301
feat(neorg): Update version #1384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
Uzaaft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick review, the proper one will come later:
Pin the plugin to 9.0.
Also relevant breaking changes:
https://vhyrro.github.io/posts/neorg-9-0-0/
|
after a quick copy paste Failed to run `config` for neorg
.../lua/neorg/modules/core/integrations/nvim-cmp/module.lua:46: attempt to index field 'lsp' (a nil value)
# stacktrace:
- /neorg/lua/neorg/modules/core/integrations/nvim-cmp/module.lua:46 _in_ **create_source**
- /neorg/lua/neorg/modules/core/completion/module.lua:314 _in_ **load**
- /neorg/lua/neorg/core/modules.lua:446 _in_ **load_module**
- /neorg/lua/neorg/init.lua:100 _in_ **org_file_entered**
- /neorg/lua/neorg/init.lua:45 _in_ **setup**didn't have time to test further |
Uzaaft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR breaks 0.9 support. So we should either:
- add both neovim 0.10 support and 0.9
or - Wait until astro v5 is released.
|
@std-enigma Any updates? U wanna wait until v5 or make the required changes? |
|
I had a bruh moment cuz I got confused by the incoming changes. Note to self: Dont merge PRs before caffeine hits. |
📑 Description
Improve neorg community package
ℹ Additional Information