Skip to content

Conversation

@lucazz
Copy link
Contributor

@lucazz lucazz commented Nov 29, 2024

📑 Description

This PR further extends the regex used to match common Ansible paths, some of them are documented best practices, even:

We're adding the following paths to the regex:

  • ansible/
  • playbooks/
  • group_vars/
  • host_vars/
  • vars/
  • tasks/

ℹ Additional Information

Here's an example on how nested variables look like in the wild:

├── ansible
│   ├── group_vars
│   ├── host_vars
│   ├── roles
│   │   ├── foo
│   │   │   ├── defaults
│   │   │   ├── tasks
│   │   │   └── vars
│   │   ├── bar
│   │   │   ├── defaults
│   │   │   ├── tasks
│   │   │   ├── templates
│   │   │   └── vars
│   │   └── baz
│   │       ├── vars
│   │       ├── defaults
│   │       └── tasks
│   └── vars
└── tests
    └── charts
        ├── hello
        │   └── templates
        │       └── tests
        └── oauth2
            └── templates
                └── tests

@github-actions
Copy link

github-actions bot commented Nov 29, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft Uzaaft changed the title fix(pack): Add support for additional Ansible directory structures in ansible's path_regex fix(pack): Add support for additional Ansible directory structures in ansible's path_regex, and correct docs Dec 1, 2024
@Uzaaft Uzaaft merged commit c5e7f6a into AstroNvim:main Dec 6, 2024
16 checks passed
@lucazz lucazz deleted the fix/ansbile-pack branch December 6, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants