Skip to content

Conversation

@rami3l
Copy link
Contributor

@rami3l rami3l commented Oct 22, 2024

📑 Description

With this PR, typst_lsp in the typst pack is replaced by tinymist.

tinymist is a more actively-developed language server for the Typst language. Since typst/typst#5193, tinymist has replaced typst_lsp to become the recommended LSP implementation in Typst's official docs.

ℹ Additional Information

Also, with this change, the user can now directly use the Mason-installed tinymist as the preview backend in chomosuke/typst-preview.nvim, without having to separately install a typst-preview server, thanks to the fact that this functionality has recently been successfully integrated into tinymist itself.

Tested locally (since over 5 months ago) with the following override:

  {
    "williamboman/mason-lspconfig.nvim",
    opts = function(_, opts)
      opts.ensure_installed =
        require("utils").list_remove_all(opts.ensure_installed, { "typst_lsp" })
      opts.ensure_installed =
        require("astrocore").list_insert_unique(opts.ensure_installed, { "tinymist" })
    end,
  },
  {
    "chomosuke/typst-preview.nvim",
    opts = {
      dependencies_bin = {
        tinymist = "tinymist",
        -- This is because `websocat` is in my `PATH` as well,
        -- but it might not generally apply to everyone.
        websocat = "websocat",
      },
    },
  },

@github-actions
Copy link

github-actions bot commented Oct 22, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft
Copy link
Member

Uzaaft commented Oct 23, 2024

tinymist doesnt seem to be recommended, its just being mentioned as an alternative.

@Uzaaft Uzaaft merged commit 6c4c080 into AstroNvim:main Oct 23, 2024
23 checks passed
@rami3l rami3l deleted the pack/typst-tinymist branch October 23, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants