Skip to content

Conversation

@mehalter
Copy link
Member

📑 Description

This does a major refactor on the grug-far.nvim spec that adds a lot more bindings and options for searching and replacing. It also aligns the recommended keymaps with what we have been using for spectre.nvim which is a very nice workflow.

ℹ Additional Information

@github-actions
Copy link

github-actions bot commented Sep 19, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@mehalter mehalter requested a review from a team September 19, 2024 15:18
Copy link
Member

@luxus luxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@luxus luxus merged commit 8100fe5 into main Sep 19, 2024
@luxus luxus deleted the grug_far_rewrite branch September 19, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants