-
Notifications
You must be signed in to change notification settings - Fork 602
fix(evals): miscellaneous fixes and ergonomic improvements #9879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t mapping when binding to avoid issues copying LLM
…lity updated to match
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
axiomofjoy
approved these changes
Oct 20, 2025
packages/phoenix-evals/src/phoenix/evals/metrics/document_relevance.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Include:
LLMto a top level import since it is commonly used with EvaluatorsBug fix:
bind_evaluatoron anLLMEvaluatorreturns an error due to attempting to deep copy theLLMobject which can't be pickled. Now the method does a shallow copy of the evaluator and only deep copies the input_mapping, which is the only property we don't want the original and copy to share.Note
Switch dataframe eval outputs to dicts, add default/hideable tqdm progress bar, expose
LLMat top level, and fixbind_evaluatorcopying; update notebooks/tests accordingly.{score}_scoreand{evaluator}_execution_detailscolumns for dataframe evals.default_tqdm_progress_bar_formatter(...)andhide_tqdm_barflag for sync/async dataframe evals.bind_evaluator(...): use shallow copy of evaluator (avoids deepcopyingLLMwith locks) and deep copy only theinput_mapping.LLMat top-level import (from phoenix.evals import LLM).to_annotation_dataframeto parse dict-backed scores; exportdefault_tqdm_progress_bar_formatter.LLM; minor notebook cleanup.Written by Cursor Bugbot for commit 6d7c3f0. This will update automatically on new commits. Configure here.