feat(Classic Footer): add option to hide "0 notes" #1986
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an off-by-default option to Classic Footer: "Hide the note count on posts with no notes".
This adds the
aria-hiddenattribute to note count buttons created by Classic Footer. If this option is enabled and the post has zero notes, it is set totrue; otherwise, it isfalse(which, for once, is actually synonymous with not having the attribute present at all).Note count buttons with
aria-hidden="true"havevisibility: hidden;applied to them, keeping them in the flex layout (which keeps the interaction buttons right-aligned with no additional CSS) but otherwise removing them from sight.Testing steps