Skip to content

Conversation

@AprilSylph
Copy link
Owner

@AprilSylph AprilSylph commented Nov 10, 2025

Description

Before After
Screen Shot 2025-11-10 at 16 46 01 Screen Shot 2025-11-10 at 16 46 17

This PR is also a refactor of the AlreadyReblogged CSS:

  • Targeting of reblog buttons has been simplified, dropping the attribute checks on the a/button in favour of relying on just the AlreadyReblogged classname on the footer and the presence of a reblog icon
  • The green/purple/red color override is now applied to the entire button, making the extra CSS for colouring the tick pseudo-element redundant

Setting --icon-color-primary is not necessary to recolour icons in the new iconset, but I've kept a rule for setting that on the icons anyway, for compatibility's sake.

Testing steps

  1. Load the modified addon with a blank config
  2. Enable Quick Reblog
  3. Use Quick Reblog to reblog a post
    • Expected result: The post's reblog icon turns green
    • Expected result: The post's reblog icon gains a green tick
    • Expected result: The reblog button's reblog count turns green
  4. Use Quick Reblog to queue a post
    • Expected result: The post's reblog icon turns purple
    • Expected result: The post's reblog icon gains a purple tick
    • Expected result: The reblog button's reblog count turns purple
  5. Use Quick Reblog to draft a post
    • Expected result: The post's reblog icon turns red
    • Expected result: The post's reblog icon gains a red tick
    • Expected result: The reblog button's reblog count count turns red
  6. Enable Classic Footer
    • Expected result: The reblogged post(s) keep their coloured reblog icons
    • Expected result: The reblogged post(s) keep their coloured ticks
  7. Disable Classic Footer's "Turn reblog buttons back into links" option
    • Expected result: No visual changes occur

Compatibility

  1. Disable the postFooterSplitNotesCountSingleAction feature, and reload the page
  2. Find the post(s) you reblogged with Quick Reblog previously
    • Expected result: Those posts have green reblog buttons, and green ticks
  3. Use Quick Reblog to queue a post
    • Expected result: The reblog button turns purple, and gains a purple tick
  4. Use Quick Reblog to draft a post
    • Expected result: The reblog button turns red, and gains a red tick

@AprilSylph AprilSylph marked this pull request as ready for review November 11, 2025 10:05
Copy link
Collaborator

@marcustyphoon marcustyphoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work on the old, never-released postFooterSplitNotesCount footer, a fact which has a non-zero chance of eventually becoming relevant, but we can deal with that if it happens.

@AprilSylph AprilSylph merged commit cea2aa5 into master Nov 12, 2025
5 checks passed
@AprilSylph AprilSylph deleted the aprilsylph/alreadyreblogged-colouration branch November 12, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quick Reblog: Reblogged status indication does not affect whole button

3 participants