chore(Panorama): Increase some CSS specificity for future compatibility #1981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcustyphoon
requested review from
AprilSylph
and removed request for
AprilSylph
marcustyphoon
changed the title
AprilSylph
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This increases the specificity of a few of the Panorama selectors using !important so it's resilient against future Tumblr changes that could use an extra feature-flag-specific class.
There are lots of ways to do this (put one of the keyToCss selectors twice,
[class],:not(.invalid-selector-for-specificity), etc). Not sure which is best. We could extract a variableconst extraSpecificity = 'whatever'which I have done on some other dev branches; I feel like a short variable name would be more elegant there but I don't have one.Testing steps
Perform the tests from #1291. (I didn't do endless-scrolling-off or patio, but like, close enough, right)