Skip to content

refactor: Popover position css #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

refactor: Popover position css #1889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/features/quick_reblog/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@
}
}

#quick-reblog.below {
#quick-reblog[data-position="below"] {
inset: 100% 50% auto auto;
transform: translate(calc(50% + var(--horizontal-offset, 0%)), var(--icon-spacing));
}
#quick-reblog.above {
#quick-reblog[data-position="above"] {
inset: auto 50% 100% auto;
transform: translate(calc(50% + var(--horizontal-offset, 0%)), calc(0px - var(--icon-spacing)));
}
Expand Down
8 changes: 4 additions & 4 deletions src/features/quick_tags/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@
font-weight: normal;
}

#quick-tags-post-option.below {
#quick-tags-post-option[data-position="below"] {
top: 100%;
right: 50%;
transform: translate(50%, 12px);
}

#quick-tags-post-option.above {
#quick-tags-post-option[data-position="above"] {
bottom: 100%;
right: 50%;
transform: translate(50%, -12px);
Expand All @@ -42,11 +42,11 @@
}
}

#quick-tags.below {
#quick-tags[data-position="below"] {
inset: 100% 50% auto auto;
transform: translate(calc(50% + var(--horizontal-offset, 0%)), var(--icon-spacing));
}
#quick-tags.above {
#quick-tags[data-position="above"] {
inset: auto 50% 100% auto;
transform: translate(calc(50% + var(--horizontal-offset, 0%)), calc(0px - var(--icon-spacing)));
}
Expand Down
4 changes: 2 additions & 2 deletions src/utils/interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ const getClosestWithOverflow = element => {
};

export const appendWithoutOverflow = (element, target, defaultPosition = 'below') => {
element.className = defaultPosition;
element.dataset.position = defaultPosition;
element.style.removeProperty('--horizontal-offset');

target.appendChild(element);
Expand All @@ -138,7 +138,7 @@ export const appendWithoutOverflow = (element, target, defaultPosition = 'below'
const elementRect = element.getBoundingClientRect();

if (elementRect.bottom > document.documentElement.clientHeight) {
element.className = 'above';
element.dataset.position = 'above';
}
if (elementRect.right > preventOverflowTargetRect.right - 15) {
element.style.setProperty('--horizontal-offset', `${preventOverflowTargetRect.right - 15 - elementRect.right}px`);
Expand Down