AccessKit Disable GIFs: Pause additional elements #1854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 31, 2025
AprilSylph
approved these changes
Aug 7, 2025
Owner
AprilSylph
left a comment
AprilSylph
left a comment
There was a problem hiding this comment.
-
figure -
linkCard- Note: I wouldn't say this is paused "correctly", as the paused GIF + label overrides the link tint + title... but, while it would be my preference to fix this prior to merging, I won't require it.
-
typeaheadRow -
tagImage -
topPost- Note: The vertical alignment is off, but it's not that big a deal...?
-
takeoverBanner- Note: Didn't test, will trust you on this one
-
communityHeaderImage -
bannerImage -
tagChicletWrapper
Co-authored-by: April Sylph <[email protected]>
Collaborator
Author
Oh, that definitely used to work. Will have to check why it doesn't anymore. Edit: Uh... not sure how it would have? worked? |
AprilSylph
reviewed
Aug 7, 2025
Co-authored-by: April Sylph <[email protected]>
Collaborator
Author
Man, I don't remember that one either. Might require copying inline styles? I guess? |
AprilSylph
approved these changes
Aug 8, 2025
Owner
AprilSylph
left a comment
AprilSylph
left a comment
There was a problem hiding this comment.
linkCard✅ Now flawlesstopPost✅ Now flawless
LGTM!
Collaborator
Author
|
How do you want to handle this stacked PR? |
Owner
|
Let's merge this into it, and then I review the modified base PR...? If I want to exclude this PR's diff, I can just... do that. |
marcustyphoon
merged commit f75f655
into
marcustyphoon/disable-gifs-poster
1 check passed
marcustyphoon
added a commit
that referenced
this pull request
Aug 8, 2025
…hover; pause additional elements (#1853, #1854) Co-authored-by: April Sylph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds additional selectors for GIFs that can be paused with minimal changes to the current Disable GIFs code and comments that list the elements referred to.
Based off of the branch for #1853 and tested that way. Note: most/all of these don't need that PR; let me know if you'd like them tested and PR'd separately. If merging both, it reduces testing to test them together (though it might require a rebase of this branch, annoyingly).
Testing steps
Note: the GIFs in the search dropdown modal don't have labels when I test this in Safari 17.6; this happens whether I use the
<p>-element or pseudo element label and I'm pretty certain it's a Safari bug with canvas elements.Edit: Smoke tested in Safari 18.1.1 on iOS. Real nice for spotty connections.