chore: rename "scripts" to "features" in code #1828
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
src/features/directory #1820 (comment)Updates
src/action/**andsrc/utils/preferences.js' internal-only terminology of "scripts" to "features", to match our new directory structure (as of v1.0.0) and our documentation.This PR intentionally does not update the
"enabledScripts"storage key or any of its usages, since this PR is already rather big, and by its nature of doing mass-renaming should be tested thoroughly; adding any migratory code for"enabledScripts"→"enabledFeatures"would fall outside the scope of this testing.I also haven't touched
src/content_scripts/main.js, because 1) that file really does primarily deal with features' scripts (being the thing that runs them), and 2) it would be confusing to update its terminology while keeping theenabledScriptsname intact.Testing steps
checkbox(as used by e.g. AccessKit)text(as used by e.g. Quick Reblog)color(as used by Painter)select(as used by e.g. AccessKit)textarea(as used by e.g. CleanFeed)iframe(as used by e.g. PostBlock)(whichever is more convenient to test)
(whichever is more convenient to test)