Build script tidy-up #922
Merged
Build script tidy-up #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
martincostello
commented
Feb 13, 2022
martincostello
commented
- Do not edit the csproj outside CI to help prevent stopping people checking in changes from local testing with the build scripts.
- Use xplat path joining.
- Fix some casing.
- Make brace styles/spacing consistent.
- Add shebang for PowerShell Core.
- Set executable bit for PowerShell Core.
- Remove redundant variable.
- Disable showing the download progress bar when downloading files.
- Skip running the tests for .NET Framework on non-Windows operating systems.
- Drop test TFM for .NET Core 2.1 as it is no longer supported.
- Speed up CI by setting some additional environment variables.
Do not edit the csproj outside CI. Use xplat path joining. Fix some casing. Make brace styles/spacing consistent. Add shebang for pwsh. Remove redundant variable.
Set the executable bit for macOS and Linux.
Disable showing the download progress bar when downloading files.
Skip running the tests for .NET Framework on non-Windows operating systems.
.NET Core 2.1 is no longer supported.
Speed up CI by setting some additional environment variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.