-
-
Couldn't load subscription status.
- Fork 1.3k
Add zizmor #2698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zizmor #2698
Conversation
martincostello
commented
Aug 12, 2025
- Use zizmor to scan the GitHub Actions workflows for vulnerabilities.
- Resolve zizmor findings.
- Bump PSScriptAnalyzer to v1.24.0.
- Use zizmor to scan the GitHub Actions workflows for vulnerabilities. - Resolve zizmor findings. - Bump PSScriptAnalyzer to v1.24.0.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds zizmor as a security scanning tool for GitHub Actions workflows and resolves the security findings it identified. It also updates PSScriptAnalyzer to version 1.24.0.
- Adds zizmor workflow security scanning with pedantic persona
- Resolves security findings by adding
persist-credentials: falseto most checkout actions - Updates PSScriptAnalyzer from v1.23.0 to v1.24.0 and removes unnecessary NuGet cache setup
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/lint.yml |
Adds zizmor security scanning, updates PSScriptAnalyzer version, adds required permissions, and removes NuGet cache |
.github/workflows/updater-approve.yml |
Adds persist-credentials: false to checkout action |
.github/workflows/release.yml |
Adds persist-credentials: false to checkout action |
.github/workflows/on-push-do-docs.yml |
Explicitly sets persist-credentials: true with zizmor ignore comment |
.github/workflows/nuget-packages-published.yml |
Adds persist-credentials: false to checkout action |
.github/workflows/mutation-tests.yml |
Adds persist-credentials: false to checkout action |
.github/workflows/gh-pages.yml |
Adds persist-credentials: false to checkout action |
.github/workflows/dependency-review.yml |
Adds persist-credentials: false to checkout action |
.github/workflows/dependabot-approve.yml |
Adds persist-credentials: false and ref parameter to checkout action, adds zizmor ignore comment |
.github/workflows/code-ql.yml |
Adds persist-credentials: false to checkout action |
.github/workflows/build.yml |
Adds persist-credentials: false to checkout action and removes NuGet cache setup |
.github/workflows/after-release.yml |
Explicitly sets persist-credentials: true with zizmor ignore comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2698 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 311 311
Lines 7322 7322
Branches 1012 1012
=======================================
Hits 7046 7046
Misses 222 222
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |