-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Refactor project dependencies #2696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Split dependencies into groups to make management easier. - Remove MSBuild variables for versions. - Fix samples using .NET 8 instead of 9. - Remove redundant properties. - Sort some properties. - Update test behaviour for Microsoft.Extensions.TimeProvider.Testing upgrade due to changes in dotnet/extensions#5783.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors project dependencies to improve maintainability and security, splitting dependencies into logical groups while removing MSBuild variables for version management. The changes standardize all sample projects to use .NET 9.0 and move common properties to Directory.Build.props files.
- Consolidates common project properties into Directory.Build.props files
- Updates sample projects from .NET 8.0 to .NET 9.0 for consistency
- Removes MSBuild variables and replaces them with explicit version declarations
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/Polly.Core.Tests/Retry/RetryResilienceStrategyTests.cs | Updates test to use standard FakeTimeProvider instead of custom throwing implementation |
| samples/*/*.csproj | Removes redundant project properties that are now inherited from Directory.Build.props |
| samples/Directory.Build.props | Adds common properties like ImplicitUsings and Nullable, sorts properties alphabetically |
| Directory.Packages.props | Removes MSBuild variables and replaces with explicit version declarations grouped by purpose |
| Directory.Build.props | Adds ManagePackageVersionsCentrally property |
| .github/dependabot.yml | Adds Polly package grouping for dependabot updates |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2696 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 311 311
Lines 7322 7322
Branches 1012 1012
=======================================
Hits 7046 7046
Misses 222 222
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Manually verified the versions referenced by the various TGMs in the NuGet packages haven't been changed. |
Fix xpath to get the previous release veresion broken by #2696.
Fix xpath to get the previous release veresion broken by #2696.
Resolves dependabot alerts for CVE-2024-30105 and CVE-2024-43485 in the DependencyInjection sample.