Skip to content

Conversation

@martincostello
Copy link
Member

  • Update various dependencies to their latest versions.
  • Add missing members to PublicAPI.Shipped.txt for Polly added by update to Microsoft.CodeAnalysis.PublicApiAnalyzers.

- Update various dependencies to their latest versions.
- Add missing members to `PublicAPI.Shipped.txt` for Polly added by update to Microsoft.CodeAnalysis.PublicApiAnalyzers.
@martincostello martincostello added CI/build dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Jul 8, 2025
@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (0459a8b) to head (b5bbf6f).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2668      +/-   ##
==========================================
- Coverage   96.23%   96.23%   -0.01%     
==========================================
  Files         311      311              
  Lines        7329     7322       -7     
  Branches     1013     1012       -1     
==========================================
- Hits         7053     7046       -7     
  Misses        222      222              
  Partials       54       54              
Flag Coverage Δ
linux 96.23% <ø> (-0.01%) ⬇️
macos 96.23% <ø> (-0.01%) ⬇️
windows 96.22% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Behaviour change causes test to fail - will upgrade to v9 at a later date.
@martincostello martincostello marked this pull request as ready for review July 8, 2025 15:06
@Copilot Copilot AI review requested due to automatic review settings July 8, 2025 15:06
@martincostello martincostello enabled auto-merge (squash) July 8, 2025 15:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates several NuGet package versions to their latest releases and synchronizes the PublicAPI.Shipped.txt file with newly detected public members introduced by the updated Microsoft.CodeAnalysis.PublicApiAnalyzers.

  • Bump of multiple package versions (e.g., BenchmarkDotNet, PublicApiAnalyzers, Test SDK, ReportGenerator, SonarAnalyzer).
  • Addition of two missing Polly API entries required by the analyzer update.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Polly/PublicAPI.Shipped.txt Added two Invoke members for ExceptionPredicate and ResultPredicate to match the analyzer’s findings.
Directory.Packages.props Updated package versions for various dependencies to their latest stable releases.
Comments suppressed due to low confidence (1)

src/Polly/PublicAPI.Shipped.txt:1054

  • The return type for ExceptionPredicate.Invoke appears incorrect—this method should return bool (indicating whether the exception matches the predicate) rather than System.Exception. Please verify the actual signature and correct the API entry.
virtual Polly.ExceptionPredicate.Invoke(System.Exception ex) -> System.Exception

@martincostello martincostello merged commit d5332bd into main Jul 8, 2025
26 checks passed
@martincostello martincostello deleted the bump-dependencies branch July 8, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/build dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant