-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update dependencies #2668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #2668
Conversation
- Update various dependencies to their latest versions. - Add missing members to `PublicAPI.Shipped.txt` for Polly added by update to Microsoft.CodeAnalysis.PublicApiAnalyzers.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2668 +/- ##
==========================================
- Coverage 96.23% 96.23% -0.01%
==========================================
Files 311 311
Lines 7329 7322 -7
Branches 1013 1012 -1
==========================================
- Hits 7053 7046 -7
Misses 222 222
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Behaviour change causes test to fail - will upgrade to v9 at a later date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates several NuGet package versions to their latest releases and synchronizes the PublicAPI.Shipped.txt file with newly detected public members introduced by the updated Microsoft.CodeAnalysis.PublicApiAnalyzers.
- Bump of multiple package versions (e.g., BenchmarkDotNet, PublicApiAnalyzers, Test SDK, ReportGenerator, SonarAnalyzer).
- Addition of two missing Polly API entries required by the analyzer update.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Polly/PublicAPI.Shipped.txt | Added two Invoke members for ExceptionPredicate and ResultPredicate to match the analyzer’s findings. |
| Directory.Packages.props | Updated package versions for various dependencies to their latest stable releases. |
Comments suppressed due to low confidence (1)
src/Polly/PublicAPI.Shipped.txt:1054
- The return type for
ExceptionPredicate.Invokeappears incorrect—this method should returnbool(indicating whether the exception matches the predicate) rather thanSystem.Exception. Please verify the actual signature and correct the API entry.
virtual Polly.ExceptionPredicate.Invoke(System.Exception ex) -> System.Exception
PublicAPI.Shipped.txtfor Polly added by update to Microsoft.CodeAnalysis.PublicApiAnalyzers.