-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Attest artifacts #2647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attest artifacts #2647
Conversation
Attest the SBOM and `lib` files in the NuGet packages.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2647 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 311 311
Lines 7329 7329
Branches 1013 1013
=======================================
Hits 7053 7053
Misses 222 222
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Attest the SBOM and the contents of the NuGet packages after they have been signed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds steps to attest the SBOM and library files in the NuGet packages by downloading the SBOM, extracting package contents, and running an attestation action.
- Added
permissions
to allow attestation. - Implemented SBOM download and package extraction in the Windows job.
- Configured
actions/attest-build-provenance
to attest both SBOM andlib
files.
Comments suppressed due to low confidence (3)
.github/workflows/build.yml:371
- [nitpick] The variable name
$packages
is ambiguous; consider renaming it to something more descriptive like$nupkgFiles
to clarify that it contains file paths.
$packages = Get-ChildItem -Filter "*.nupkg" | ForEach-Object { $_.FullName }
.github/workflows/build.yml:372
- Consider explicitly creating the root
artifacts
directory (e.g.,New-Item -ItemType Directory -Path $artifactsPath
) before extracting packages, to avoid errors if the SBOM download step fails.
$artifactsPath = Join-Path ${env:GITHUB_WORKSPACE} "artifacts"
.github/workflows/build.yml:390
- The glob pattern
./artifacts/*/lib/**/*
may match directories as well as files; consider specifying file extensions (e.g.,./artifacts/*/lib/**/*.dll
) or adjusting the pattern to only include the intended artifact files.
./artifacts/*/lib/**/*
Verified using the Polly 8.6.1 release by:
|
Attest the SBOM and
lib
files in the NuGet packages.