-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update maxQueuingCompounded in BulkheadSemaphoreFactory #2638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dotnet-policy-service agree |
|
Thanks for the PR - could you add a test for this please that validates the exception is no longer thrown? |
|
@martincostello added unit tests |
Co-authored-by: Martin Costello <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2638 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 311 311
Lines 7329 7329
Branches 1013 1013
=======================================
Hits 7053 7053
Misses 222 222
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks! |
Pull Request
The issue or feature being addressed
Fixes #2637, caused by overflow in
BulkheadSemaphoreFactory.Details on the issue fix or feature implementation
Set compound math to long before evaluating Min with int.MaxValue.
Confirm the following