Skip to content

Conversation

@ahusseini
Copy link
Contributor

Pull Request

The issue or feature being addressed

Fixes #2637, caused by overflow in BulkheadSemaphoreFactory.

Details on the issue fix or feature implementation

Set compound math to long before evaluating Min with int.MaxValue.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@ahusseini ahusseini changed the title Update maxQueuingCompounded Update maxQueuingCompounded in BulkheadSemaphoreFactory Jun 10, 2025
@ahusseini
Copy link
Contributor Author

@dotnet-policy-service agree

@martincostello
Copy link
Member

Thanks for the PR - could you add a test for this please that validates the exception is no longer thrown?

@ahusseini
Copy link
Contributor Author

@martincostello added unit tests

@martincostello martincostello added this to the v8.6.1 milestone Jun 10, 2025
@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (2f078f9) to head (b246dfe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2638   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         311      311           
  Lines        7329     7329           
  Branches     1013     1013           
=======================================
  Hits         7053     7053           
  Misses        222      222           
  Partials       54       54           
Flag Coverage Δ
linux 96.23% <100.00%> (ø)
macos 96.23% <100.00%> (ø)
windows 96.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello enabled auto-merge (squash) June 10, 2025 22:24
@martincostello martincostello merged commit bbe8807 into App-vNext:main Jun 10, 2025
26 checks passed
@martincostello
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ArgumentOutOfRangeException in BulkheadSemaphoreFactory when passing int.MaxValue for maxQueueingActions

2 participants