Skip to content

Conversation

@martincostello
Copy link
Member

Tidies up various bits of code in Polly.Specs.

  • Suppress CA1062, SA1204 and SA1600 warnings centrally for test projects.
  • Suppress S104 and S6966 in editorconfig.
  • Suppress the CA1030, CA2008 and CA2201 warnings in Polly.Specs.
  • Suppress CA1031 at the two usages and re-enable.
  • Apply various IDE suggestions to simplify/modernise code.

Contributes to #1290.

Suppress CA1062, SA1204 and SA1600 warnings centrally for test projects.
Suppress S104 and S6966 in editorconfig.
Suppress the CA2008 and CA2201 warnings in Polly.Specs.
Suppress CA1031 at the two usages and re-enable.
Suppress CA1030 for Polly.Specs.
Apply various IDE suggestions to simplify/modernise code.
Simplify objection creation.
@martincostello martincostello marked this pull request as ready for review January 27, 2025 17:45
@martincostello martincostello enabled auto-merge (rebase) January 27, 2025 17:46
@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (bf6bdb9) to head (697d280).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2466   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         312      312           
  Lines        7464     7464           
  Branches     1121     1121           
=======================================
  Hits         6371     6371           
  Misses        908      908           
  Partials      185      185           
Flag Coverage Δ
linux 85.35% <ø> (ø)
macos 85.35% <ø> (ø)
windows 85.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 7148503 into main Jan 27, 2025
24 checks passed
@martincostello martincostello deleted the gh-1290 branch January 27, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant