-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove CA2211 NoWarn #2316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove CA2211 NoWarn #2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
approved these changes
Sep 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2316 +/- ##
=======================================
Coverage 85.38% 85.38%
=======================================
Files 313 313
Lines 7457 7457
Branches 1126 1126
=======================================
Hits 6367 6367
Misses 745 745
Partials 345 345
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Jul 30, 2025
This was referenced Aug 18, 2025
This was referenced Sep 2, 2025
This was referenced Sep 22, 2025
This was referenced Sep 29, 2025
This was referenced Oct 1, 2025
This was referenced Oct 9, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
#1290
Details on the issue fix or feature implementation
I found that both classes SystemClock and TaskHelper are declared in the Polly/PublicAPI.Shipped.txt, so I opt for disabling the warning locally to prevent adding new cases without editing the shipped API.
We can make the TaskHelper.EmptyTask get-only property and we can make SystemClock an internal class if they weren't in the shipped api.
Confirm the following