- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.3k
[Docs] Use docfx to dynamically render mermaid diagrams #1701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Use docfx to dynamically render mermaid diagrams #1701
Conversation
| Codecov ReportAll modified lines are covered by tests ✅ 
 Additional details and impacted files@@           Coverage Diff           @@
##             main    #1701   +/-   ##
=======================================
  Coverage   84.63%   84.63%           
=======================================
  Files         306      306           
  Lines        6819     6819           
  Branches     1045     1045           
=======================================
  Hits         5771     5771           
  Misses        839      839           
  Partials      209      209           
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. | 
| After scrutinizing the relevant documentation it turned out mermaid is supported by the modern template. I checked it locally and it works. I'm repurposing this PR to enable mermaid diagrams. | 
Head branch was pushed to by a user without write access
|  | ||
| <!-- ```mermaid | ||
| ```mermaid | ||
| %%{init: {'theme':'dark'}}%% | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Pull Request
The issue or feature being addressed
Details on the issue fix or feature implementation
Proof
Note: The built-in themes are either optimized for white or black background. Only the dark is legible in both cases
Dark theme
Light theme
Confirm the following