Skip to content

Logging improvements #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Logging improvements #1489

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f534a5
Logging renames
martintmk Aug 15, 2023
d5971c5
Merge remote-tracking branch 'origin/main' into mtomka/improve-logs
martintmk Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/Polly.Extensions/Telemetry/Log.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,16 @@ internal static partial class Log
EventId = 0,
Message = "Resilience event occurred. " +
"EventName: '{EventName}', " +
"Source: '{BuilderName}/{BuilderInstance}/{StrategyName}', " +
"Source: '{PipelineName}/{PipelineInstance}/{StrategyName}', " +
"Operation Key: '{OperationKey}', " +
"Result: '{Result}'",
EventName = "ResilienceEvent")]
public static partial void ResilienceEvent(
this ILogger logger,
LogLevel logLevel,
string eventName,
string builderName,
string builderInstance,
string pipelineName,
string pipelineInstance,
string? strategyName,
string? operationKey,
object? result,
Expand All @@ -31,21 +31,21 @@ public static partial void ResilienceEvent(
1,
LogLevel.Debug,
"Resilience pipeline executing. " +
"Source: '{BuilderName}/{BuilderInstance}', " +
"Source: '{PipelineName}/{PipelineInstance}', " +
"Operation Key: '{OperationKey}', " +
"Result Type: '{ResultType}'",
EventName = "StrategyExecuting")]
public static partial void PipelineExecuting(
this ILogger logger,
string builderName,
string builderInstance,
string pipelineName,
string pipelineInstance,
string? operationKey,
string resultType);

[LoggerMessage(
EventId = 2,
Message = "Resilience pipeline executed. " +
"Source: '{BuilderName}/{BuilderInstance}', " +
"Source: '{PipelineName}/{PipelineInstance}', " +
"Operation Key: '{OperationKey}', " +
"Result Type: '{ResultType}', " +
"Result: '{Result}', " +
Expand All @@ -55,8 +55,8 @@ public static partial void PipelineExecuting(
public static partial void PipelineExecuted(
this ILogger logger,
LogLevel logLevel,
string builderName,
string builderInstance,
string pipelineName,
string pipelineInstance,
string? operationKey,
string resultType,
object? result,
Expand All @@ -67,7 +67,7 @@ public static partial void PipelineExecuted(
[LoggerMessage(
EventId = 3,
Message = "Execution attempt. " +
"Source: '{BuilderName}/{BuilderInstance}/{StrategyName}', " +
"Source: '{PipelineName}/{PipelineInstance}/{StrategyName}', " +
"Operation Key: '{OperationKey}', " +
"Result: '{Result}', " +
"Handled: '{Handled}', " +
Expand All @@ -78,8 +78,8 @@ public static partial void PipelineExecuted(
public static partial void ExecutionAttempt(
this ILogger logger,
LogLevel level,
string builderName,
string builderInstance,
string pipelineName,
string pipelineInstance,
string strategyName,
string? operationKey,
object? result,
Expand Down