Skip to content

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 14, 2023

Details on the issue fix or feature implementation

  • Drop CompositeStrategyBuilder.Randomizer and move it to RetryStrategyOptions.Randomizer
  • Drop CompositeStrategyBuilder.Properties (not used anywhere)

For context:
#1233 (comment)

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #1485 (81ccdac) into main (76f181f) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
- Coverage   83.89%   83.85%   -0.05%     
==========================================
  Files         278      277       -1     
  Lines        6496     6478      -18     
  Branches     1016     1016              
==========================================
- Hits         5450     5432      -18     
  Misses        837      837              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 83.85% <100.00%> (-0.05%) ⬇️
windows 83.85% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../Polly.Core/Registry/ResiliencePipelineRegistry.cs 100.00% <ø> (ø)
.../Polly.Core/Telemetry/ResilienceTelemetrySource.cs 100.00% <ø> (ø)
...dencyInjection/PollyServiceCollectionExtensions.cs 100.00% <ø> (ø)
...c/Polly.RateLimiting/RateLimiterStrategyOptions.cs 100.00% <ø> (ø)
src/Polly.Core/ResiliencePipelineBuilderBase.cs 100.00% <100.00%> (ø)
.../Retry/RetryResiliencePipelineBuilderExtensions.cs 100.00% <100.00%> (ø)
src/Polly.Core/Retry/RetryResilienceStrategy.cs 100.00% <100.00%> (ø)
...c/Polly.Core/Retry/RetryStrategyOptions.TResult.cs 100.00% <100.00%> (ø)
src/Polly.Core/StrategyBuilderContext.cs 100.00% <100.00%> (ø)
src/Polly.Core/Telemetry/TelemetryUtil.cs 100.00% <100.00%> (ø)

@martintmk martintmk marked this pull request as ready for review August 14, 2023 09:59
@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 14, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 14, 2023
@martintmk martintmk enabled auto-merge (squash) August 14, 2023 10:33
@martintmk martintmk merged commit 4a8c59a into main Aug 14, 2023
@martintmk martintmk deleted the mtomka/api-review-2 branch August 14, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants