Skip to content

Conversation

@martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 13, 2023

Details on the issue fix or feature implementation

  • ResilienceRateLimiter is now disposable
  • Dropped OnTimeoutArguments.Exception

Contributes to #1233

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 13, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 13, 2023
@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #1484 (db2a466) into main (fc58ddc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
+ Coverage   83.88%   83.89%   +0.01%     
==========================================
  Files         278      278              
  Lines        6491     6496       +5     
  Branches     1014     1016       +2     
==========================================
+ Hits         5445     5450       +5     
  Misses        837      837              
  Partials      209      209              
Flag Coverage Δ
linux 83.89% <100.00%> (+0.01%) ⬆️
macos 83.89% <100.00%> (?)
windows 83.89% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Polly.Core/Timeout/OnTimeoutArguments.cs 100.00% <100.00%> (ø)
...rc/Polly.Core/Timeout/TimeoutResilienceStrategy.cs 100.00% <100.00%> (ø)
src/Polly.RateLimiting/ResilienceRateLimiter.cs 100.00% <100.00%> (ø)

@martintmk martintmk changed the title API Review feedback API Review feedback (1) Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants