Skip to content

Conversation

@martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 27, 2023

Details on the issue fix or feature implementation

The Builder is redundant as it's clear because we are in ResilienceStrategyBuilder class.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 27, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #1437 (44639f0) into main (7dc06c0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1437   +/-   ##
=======================================
  Coverage   83.92%   83.92%           
=======================================
  Files         276      276           
  Lines        6524     6524           
  Branches     1006     1006           
=======================================
  Hits         5475     5475           
  Misses        840      840           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 83.92% <100.00%> (ø)
windows 83.92% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../Polly.Core/Registry/ResilienceStrategyRegistry.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceStrategyBuilderBase.cs 100.00% <100.00%> (ø)
...ry/TelemetryResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants