Skip to content

Conversation

@martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 26, 2023

Details on the issue fix or feature implementation

Just simplifying the implementation and cleaning some code.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 26, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 26, 2023
@martintmk martintmk force-pushed the mtomka/cleanup-outcomeresiiencestrategy branch from 15edaeb to faa77a2 Compare July 26, 2023 06:39
@martintmk
Copy link
Contributor Author

@vany0114 You are using this class in Simmy too. This should simplify your scenarios as well.

@martintmk martintmk enabled auto-merge (squash) July 26, 2023 06:44
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1430 (367411d) into main (0cebeea) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1430   +/-   ##
=======================================
  Coverage   83.92%   83.93%           
=======================================
  Files         275      276    +1     
  Lines        6526     6528    +2     
  Branches     1007     1005    -2     
=======================================
+ Hits         5477     5479    +2     
  Misses        840      840           
  Partials      209      209           
Flag Coverage Δ
linux 83.93% <100.00%> (+<0.01%) ⬆️
macos 83.93% <100.00%> (+<0.01%) ⬆️
windows 83.93% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Polly.Core/Retry/RetryResilienceStrategy.cs 100.00% <ø> (ø)
.../Retry/RetryResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
...CircuitBreaker/CircuitBreakerResilienceStrategy.cs 100.00% <100.00%> (ø)
...rcuitBreakerResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
.../Polly.Core/Fallback/FallbackResilienceStrategy.cs 100.00% <100.00%> (ø)
...ack/FallbackResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
...rc/Polly.Core/Hedging/HedgingResilienceStrategy.cs 100.00% <100.00%> (ø)
...ging/HedgingResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
src/Polly.Core/Utils/OutcomeResilienceStrategy.cs 100.00% <100.00%> (ø)
src/Polly.Core/Utils/TaskHelper.cs 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants