Skip to content

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 21, 2023

Details on the issue fix or feature implementation

  • Drop ResilienceStrategyOptions.StrategyType
  • Hide ResilienceContext.CancellationToken setter
  • ResilienceProperties does not implement IDictionary anymore
  • Improve RetryCount validation (1..int.MaxValue)

Contributes to #1365

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 21, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #1420 (c462b3c) into main (284e3d1) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1420      +/-   ##
==========================================
- Coverage   83.83%   83.75%   -0.09%     
==========================================
  Files         274      274              
  Lines        6491     6456      -35     
  Branches     1008     1007       -1     
==========================================
- Hits         5442     5407      -35     
  Misses        840      840              
  Partials      209      209              
Flag Coverage Δ
linux 83.75% <100.00%> (-0.09%) ⬇️
macos 83.75% <100.00%> (-0.09%) ⬇️
windows 83.75% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lly.Core/CircuitBreaker/CircuitBreakerConstants.cs 100.00% <ø> (ø)
...re/CircuitBreaker/CircuitBreakerStrategyOptions.cs 100.00% <ø> (ø)
...y.Core/Fallback/FallbackStrategyOptions.TResult.cs 100.00% <ø> (ø)
src/Polly.Core/Hedging/HedgingConstants.cs 100.00% <ø> (ø)
...lly.Core/Hedging/HedgingStrategyOptions.TResult.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceProperties.cs 100.00% <ø> (ø)
.../Polly.Core/ResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
src/Polly.Core/Retry/RetryConstants.cs 100.00% <ø> (ø)
...c/Polly.Core/Retry/RetryStrategyOptions.TResult.cs 100.00% <ø> (ø)
src/Polly.Core/Timeout/TimeoutStrategyOptions.cs 100.00% <ø> (ø)
... and 11 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants