Skip to content

Conversation

@martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 16, 2023

Details on the issue fix or feature implementation

The original name is too wordy and it's already in Polly.Extensions.Telemetry namespace.

Contributes to #1301

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 16, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 16, 2023
@martintmk martintmk enabled auto-merge (squash) June 16, 2023 14:30
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1318 (637bd21) into main (488bc10) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1318   +/-   ##
=======================================
  Coverage   83.29%   83.29%           
=======================================
  Files         264      264           
  Lines        6305     6305           
  Branches      997      997           
=======================================
  Hits         5252     5252           
  Misses        844      844           
  Partials      209      209           
Flag Coverage Δ
linux 83.29% <100.00%> (ø)
macos ?
windows 83.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/Polly.Extensions/Telemetry/EnrichmentContext.cs 100.00% <ø> (ø)
src/Polly.Extensions/Telemetry/TelemetryOptions.cs 100.00% <ø> (ø)
...dencyInjection/PollyServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
...s/Telemetry/ResilienceTelemetryDiagnosticSource.cs 100.00% <100.00%> (ø)
...ry/TelemetryResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit 5c341d5 into main Jun 16, 2023
@martintmk martintmk deleted the mtomka/TelemetryOptions branch June 16, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants