Skip to content

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 16, 2023

Details on the issue fix or feature implementation

Closes #1313

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 16, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 16, 2023
@martintmk martintmk enabled auto-merge (squash) June 16, 2023 14:06
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1316 (f16ca6c) into main (4524822) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1316      +/-   ##
==========================================
+ Coverage   83.28%   83.33%   +0.05%     
==========================================
  Files         264      264              
  Lines        6301     6320      +19     
  Branches      997     1000       +3     
==========================================
+ Hits         5248     5267      +19     
  Misses        844      844              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 83.33% <100.00%> (+0.05%) ⬆️
windows 83.33% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/CircuitBreaker/CircuitBreakerStrategyOptions.cs 100.00% <100.00%> (ø)
...lly.Core/Hedging/HedgingStrategyOptions.TResult.cs 100.00% <100.00%> (ø)
...c/Polly.Core/Retry/RetryStrategyOptions.TResult.cs 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@martintmk martintmk merged commit e15b969 into main Jun 16, 2023
@martintmk martintmk deleted the mtomka/outcome-based-options-defaults branch June 16, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[V8] ShouldHandle, ShouldRetry etc. predicates should have reasonable defaults
2 participants