Skip to content

Conversation

@martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 16, 2023

Details on the issue fix or feature implementation

Improving the telemetry benchmark. It revealed we have some work to do on allocations. I believe we can bring those to 0 if we use pooling.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 16, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1311 (cd439a9) into main (476f354) will not change coverage.
The diff coverage is n/a.

❗ Current head cd439a9 differs from pull request most recent head 358d03b. Consider uploading reports for the commit 358d03b to get more accurate results

@@           Coverage Diff           @@
##             main    #1311   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files         264      264           
  Lines        6301     6301           
  Branches      997      997           
=======================================
  Hits         5248     5248           
  Misses        844      844           
  Partials      209      209           
Flag Coverage Δ
linux 83.28% <ø> (ø)
macos 83.28% <ø> (ø)
windows 83.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@martintmk martintmk enabled auto-merge (squash) June 16, 2023 09:02
@martintmk martintmk merged commit 4524822 into main Jun 16, 2023
@martintmk martintmk deleted the mtomka/update-telemetrybenchmark branch June 16, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants