Skip to content

Conversation

@martintmk
Copy link
Contributor

@martintmk martintmk commented May 23, 2023

Details on the issue fix or feature implementation

I got tired of always updating the README.md with the latest results. It's better to just add the markdown output directly to the repo.

Additional changes:

  • Fixed timeout benchmark which got broken recently.
  • Simplified running the benchmarks. (options to run all or pick them)
  • Added new benchmark.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk requested a review from martincostello May 23, 2023 05:52
@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label May 23, 2023
@martintmk martintmk added this to the v8.0.0 milestone May 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.31%. Comparing base (e4540c8) to head (e231b1b).
⚠️ Report is 1280 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1206   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files         277      277           
  Lines        6286     6286           
  Branches     1023     1023           
=======================================
  Hits         5237     5237           
  Misses        844      844           
  Partials      205      205           
Flag Coverage Δ
linux 83.31% <ø> (?)
macos ?
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk changed the title Upload benchmark results Improve benchmarks May 23, 2023
@martintmk martintmk merged commit cc28c5e into main May 23, 2023
@martintmk martintmk deleted the mtomka/upload-benchmark-results branch May 23, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants