[Feature request]: Resilience Event occured logs should be configurable as Warning unless it's the final attempt that failed

[sander1095]

Is your feature request related to a specific problem? Or an existing feature?

Polly reports Resilience Event occurred .. logs as Error, even when it's the first attempt that failed and multiple attempts will still be made.

This makes the log show up as an error, possibly setting off alerts even though it isn't really an error until the retry mechanisms have truly failed.

Describe the solution you'd like

I would like to be able to configure failed retries to get logged as Warning. When the final attempt fails, that could then be logged as an error.

This means that I will only see true errors (that might need investigation) in my error screen.

Additional context

No response

[martincostello]

Have you tried doing this with the changes from #2072 that are in Polly 8.4.0?

[sander1095]

I seem to have overlooked that one. I just had a look, but it seems that you can only set the severity based on the (original) Severity and the EventName. I do not think that is enough to implement this feature request, as I would also need something like IsFinalAttempt or Attempt and MaxAttempts.

Also, I'm using Microsoft.Extensions.Http.Resilience instead of a direct dependency on Polly. I do not see a way to do access the TelemetryOptions in the same way when using that package. However, that's an issue related to that package and not Polly directly.

[martintmk]

@martincostello

I am thinking that this might be even good default behavior for retry strategy? Individual attempts are warnings while the final one is error?

[martincostello]

I guess that's a reasonable if we have access to the context to know if it's the last attempt.

[github-actions]

This issue is stale because it has been open for 60 days with no activity. It will be automatically closed in 14 days if no further updates are made.

[sander1095]

Any update on this? Would it be feasible and a useful addition?

/Cc @martincostello @martintmk

[martincostello]

No update from us. Feel free to open a pull request to propose this change, then we can take a look.

[peter-csala]

I'll be off in the next two weeks, but I can start work on this request on the 16th of September week if that's not too late.

[peter-csala]

As I can see no one has jump on this request in my absence so, @martincostello please assign this ticket to me.