Skip to content

[Issue #15] fix trino query execution issues in flink mode #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gengdy1545 wants to merge 2 commits into
base: dev/flinkWriter
Choose a base branch
from
Open

[Issue #15] fix trino query execution issues in flink mode #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce57b95
fix: monitored tables are not registered in flink mode
gengdy1545 Dec 19, 2025
9f029d6
fix: cannot exec query for iceberg in flink mode
gengdy1545 Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 38 additions & 5 deletions src/main/java/io/pixelsdb/pixels/sink/freshness/FreshnessClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,13 @@ protected Connection createNewConnection(long queryTimestamp) throws SQLExceptio

Properties properties = new Properties();
properties.setProperty("user", trinoUser);
String catalogName = "pixels";
String sessionPropValue = String.format("%s.query_snapshot_timestamp:%d", catalogName, queryTimestamp);

properties.setProperty("sessionProperties", sessionPropValue);
String catalog = parseCatalogFromUrl(trinoJdbcUrl);
if (catalog != null && catalog.equalsIgnoreCase("pixels"))
{
String sessionPropValue = String.format("%s.query_snapshot_timestamp:%d", catalog, queryTimestamp);
properties.setProperty("sessionProperties", sessionPropValue);
}
return DriverManager.getConnection(trinoJdbcUrl, properties);
}

Expand Down Expand Up @@ -227,7 +230,7 @@ public void stop()

private void submitQueryTask()
{
if (monitoredTables.isEmpty())
if (!config.isSinkMonitorFreshnessEmbedStatic() && monitoredTables.isEmpty())
{
LOGGER.debug("No tables configured for freshness monitoring. Skipping submission cycle.");
return;
Expand Down Expand Up @@ -398,4 +401,34 @@ private List<String> getStaticList()
{
return config.getSinkMonitorFreshnessEmbedTableList();
}
}

private String parseCatalogFromUrl(String url)
{
if (url == null || !url.startsWith("jdbc:trino://"))
{
return null;
}
String withoutProtocol = url.substring("jdbc:trino://".length());
int slashIndex = withoutProtocol.indexOf('/');
if (slashIndex == -1)
{
return null;
}
String remaining = withoutProtocol.substring(slashIndex + 1);

int nextSlash = remaining.indexOf('/');
int questionMark = remaining.indexOf('?');

int endIndex = remaining.length();
if (nextSlash != -1)
{
endIndex = nextSlash;
}
if (questionMark != -1 && questionMark < endIndex)
{
endIndex = questionMark;
}

return remaining.substring(0, endIndex);
}
}
2 changes: 2 additions & 0 deletions src/main/java/io/pixelsdb/pixels/sink/writer/flink/PixelsPollingServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import io.pixelsdb.pixels.sink.util.FlushRateLimiter;
import io.pixelsdb.pixels.sink.writer.flink.FlinkPollingWriter;
import io.pixelsdb.pixels.sink.util.DataTransform;
import io.pixelsdb.pixels.sink.freshness.FreshnessClient;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down Expand Up @@ -70,6 +71,7 @@ public PixelsPollingServiceImpl(FlinkPollingWriter writer) {
public void pollEvents(SinkProto.PollRequest request, StreamObserver<SinkProto.PollResponse> responseObserver) {
SchemaTableName schemaTableName = new SchemaTableName(request.getSchemaName(), request.getTableName());
LOGGER.debug("Received poll request for table '{}'", schemaTableName);
FreshnessClient.getInstance().addMonitoredTable(request.getTableName());
List<SinkProto.RowRecord> records = new ArrayList<>(pollBatchSize);

try {
Expand Down