Disable unused Mesos services

[DavidWittman]

Closes #44

[ninthnails]

Very neat stuff! I came across this issue many times wondering why the hell slave service was started even though i was not suppose to install it. Now it all make sense!

One thing I would like to see though is simple test in the build playbook. That won't be trivial to do but it will increase robustness of the role. Unfortunately the tests only install in master-slave. Some refactor needed.

[DavidWittman]

👍 for better testing around these types of things. Have you guys used Molecule at all? I've been using Test Kitchen for testing most of my roles but this looks much better suited for Ansible.

[JasonGiedymin]

Almost all our roles "try" to use vagrant. The ci/ playbook simply uses this role. See here and here.

This is somewhat similar to how molecule works. In fact many of the things it does we do here albeit more verbosely.

See this repo's Vagrantfile and Zookeeper Vagrantfile.

The things I like about this are:

• uses vagrant, easy to get on any platform (along with vbox or parallels if that suites your fancy)
• uses tests written with ansible
• no need for additional dependencies
• weirdly enough you can have the same tests triggered with travis, see here

[JasonGiedymin]

That being said, if it helps with easing testing than what we've already got here I'm all for it.

[ernestas-poskus]

@DavidWittman bump version https://github.com/AnsibleShipyard/ansible-mesos/blob/master/vars/main.yml#L2 and this will get merged

[DavidWittman]

@ernestas-poskus rebased and bumped version

[ernestas-poskus]

@DavidWittman please squash commits

[DavidWittman]

You can squash them on merge now in Github if you so please.
On Jun 6, 2016 12:18 PM, "Ernestas Poskus" [email protected] wrote:

@DavidWittman https://github.com/DavidWittman please squash commits

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#45 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AArmL7vnpyO5BHxXjcPnR_gAUnRcTTZKks5qJFZ6gaJpZM4HcgJk
.

[ernestas-poskus]

@DavidWittman

I have no permissions to enable Github squash, please do it on your side.

[DavidWittman]

@ernestas-poskus You don't have this option?

[ernestas-poskus]

@DavidWittman

Unfortunately no

so as Settings for repo are absent

[DavidWittman]

@ernestas-poskus You have to click "Merge pull request" first and then you'll get a dropdown on the "Confirm merge" button. It's confusing.

[ernestas-poskus]

You got me 😄 this is the first time I am doing this without CLI

[ernestas-poskus]

Thank you for contribution 🙇