Refactor search

[elsand]

This attempts to adress several issues with todays search

• As these queries must be split anyway to avoid cartesian explosions, the handler is changed to initially fetch a minimal list of dialog ids (without any joins, but with all filters). The resulting dialog-id list is then used as input for subsequent calls.
• The automapper profile for DialogEntity->IntermediateDialogDto is simplified, and mapping logic is moved to IntermediateDialogDto->DialogDto. This creates much simpler SQL which appears to perform better.
• The deleted-query filter is ignored, and deleted handling is moved to dialog Id-materialization step

Local testing (with appx 1M dialogs) seems to reduce cold service owner requests filtering on party from ~600ms to 350ms, hot lookups from ~100ms to ~60ms. This appears to be due to CPU-wins in postgresql. I/O overhead for cold requests are still assumed to dominate time spent.

Issues

• Sorting and pagination is broken (not sure how to fix it, pagination code is very opaque)
• ServiceOwnerContext and EnduserContext is JOINed for every sub-query (not clear why)
• Only implemented in serviceowner (easy to port to enduser when done)

Further improvements

• Intersect serviceowner resourceIds when supplying enduser id to improve performance of dialog id materialization
• Partial index with Deleted
• Create index with INCLUDING on the timestamp columns, deleted, serviceowner and party. This will cause the initial id-loopkup to be a index-only scan, avoiding the heap for even cold lookups
• Change default sort order i API to match arbeidsflate (contentupdatedat DESC)
• Cluster all immediate children of Dialog on DialogId

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refactor-search-tmp

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate failed

Failed conditions
4.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud