Crossout rework #1119
Open
Crossout rework #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strtgbb
force-pushed
the
crossout_rework
branch
2 times, most recently
from
7d13673 to
f5d8e68
Compare
Collaborator
Author
|
A major issue with the new implementation is that since crossout reason is not uploaded to the database, and a test fail can match multiple rules, the report cannot be 100% certain of the reason a test was crossed out. The crossout system does log the reason, it's appended to the test logs for stateless, and for integration tests a dedicated log file is written. |
strtgbb
force-pushed
the
crossout_rework
branch
4 times, most recently
from
bc05ec3 to
ab9b0b2
Compare
strtgbb
force-pushed
the
crossout_rework
branch
2 times, most recently
from
fda8856 to
1aa8304
Compare
make sure to use short test name with log extraction
update report to handle new known fails format allow message to be optional again fix broken tests report when there are no fails fixes and debug logging more debugging more debugging and fix not_message handling more debug and fix report fix broken tests report when check_types unspecified support opening logs with invalid chars in extract_fail_logs debugging missing integration tests logs fix get_log_paths returning compressed files use regex to match sanitizer timeouts
update broken_tests.yaml
strtgbb
force-pushed
the
crossout_rework
branch
from
288619a to
00487dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Tasks
Note that pattern matching on test names makes it more difficult to exclude tests that upstream has designated as BROKEN from the report. However, at this time, there is only one such upstream test.
CI/CD Options
Exclude tests:
Regression jobs to run: