-
Notifications
You must be signed in to change notification settings - Fork 66
Codegen cleanup #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codegen cleanup #77
Conversation
put common statements out of switch-case
|
@gucio321 |
AllenDang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Sure! I'm going to focus on giu as soon as cimgui-go shares all the necessary functions. |
Hi there!
First of all, I'm sorry for this being so large PR. The situation got a bit out of control. 😄
I'll try to briefly point what was changed here but forgive if I've missed something
In general I go rid of this large
generateGoFuncsfunction - it is now of human-readable sizegengo.gointo a several files (one for each "datatype") - the further steps are forgengo_funcs.go- it is the most complex onegenerateGoFuncsfunction into several smaller stepsLet me know what do you think about these changes as well as feel free to suggest another one!
IMO the code is easier to read now but let me know if it isn't ;-)