Skip to content

Codegen: cleanup #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gucio321 merged 8 commits into from
Jan 3, 2023
Merged

Codegen: cleanup #71

gucio321 merged 8 commits into from
Jan 3, 2023

Conversation

@gucio321
Copy link
Collaborator

@gucio321 gucio321 commented Dec 19, 2022

Hi!
another of codegen cleaups:

  • split main.go file into several smaller
  • make functions return he errors instead of calling panic instantly

AllenDang
AllenDang approved these changes Jan 3, 2023
View reviewed changes
Copy link
Owner

@AllenDang AllenDang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me.

@gucio321 gucio321 merged commit 4e1c0ae into AllenDang:main Jan 3, 2023
@gucio321 gucio321 deleted the codegen-cleanup branch January 3, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AllenDang AllenDang AllenDang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gucio321 @AllenDang