codegen: bunch of refactors #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(const) char** and (const) char* const[] is wraped as []string
- each type should have only the toC and fromC methods - `wrap` function is now generic and applies for any extra type
eliasdaler
reviewed
Dec 18, 2022
eliasdaler
suggested changes
Dec 19, 2022
Contributor
eliasdaler
left a comment
eliasdaler
left a comment
There was a problem hiding this comment.
Looks much better. Think one thing might still be improved.
eliasdaler
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is a bit large PR. I call it "codegen refactor". The following things has been added/changed:
Plot_PlotPieChart*#33 close Pie chart: fix generation #54 )wrappableType. it is responsible for converting GO value to and fro C.wrapmethod (replacing all the wrap methods from extra_types.go) that converts given GO pointer into C pointer and finisher funcfeel free to review and request changes!