Skip to content

Conversation

@gucio321
Copy link
Collaborator

fix #55

@gucio321 gucio321 marked this pull request as ready for review December 13, 2022 17:06
@gucio321 gucio321 marked this pull request as draft December 13, 2022 17:06
@gucio321
Copy link
Collaborator Author

I'm going to do the same for slice types

@gucio321
Copy link
Collaborator Author

and one more note:
fore some reasons, IDEs thinks the conversions in the code as build issues (e.g. goland: https://youtrack.jetbrains.com/issue/GO-14048/false-build-failure-with-generics) but it compiles normally

@gucio321 gucio321 force-pushed the wrapper-use-generics branch from 8dc4d84 to 71bbb83 Compare December 13, 2022 17:41
@gucio321
Copy link
Collaborator Author

I'm going to do the same for slice types

well nevermind - it is not used the way I tought it is 😄

@gucio321 gucio321 marked this pull request as ready for review December 13, 2022 17:44
@eliasdaler
Copy link
Contributor

Please don't use PR's for drafts - develop in your own fork. It pollutes notifications - I'm only interested in final code.

@gucio321 gucio321 force-pushed the wrapper-use-generics branch from 1af4f2e to c60c582 Compare December 13, 2022 18:45
@gucio321
Copy link
Collaborator Author

it is already ready for review

@gucio321 gucio321 requested a review from eliasdaler December 14, 2022 11:06
@eliasdaler eliasdaler merged commit 1c63b36 into AllenDang:main Dec 14, 2022
@gucio321 gucio321 deleted the wrapper-use-generics branch December 14, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

idea: use generics in type_wrapper.go

2 participants