Codegen: compile-in gofumpt #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generally calling formatters on the generated code should be done by generator itself. Current apprach was: it generates something and if you want to read this gofumpt it yourself
now makefile dosn't call gofumpt at all
Collaborator
Author
|
This also speeds up generation process around 3 times! statsbefore:real 0m30.392s
user 1m3.656s
sys 0m37.289safter: real 0m8.141s
user 0m37.917s
sys 0m25.941s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as said in the 1st commit, codegen should use gofumpt internally rather than requiring user to do so.