Glfw submodule #40
Merged
Glfw submodule #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
strange... It seems that cimgui/cimplot submodules has been changed in my commits, but cant imagine why 😄 |
Contributor
|
Try going inside git submodule dir and checking out to the same commits as in master now. |
Collaborator
Author
|
oh, thanx, it works! |
Contributor
|
Looks good. Now the only thing left is to move cimgui and cimplot to "thirdparty". |
Collaborator
Author
|
Well @eliasdaler but i'd do that in a separate pr since it's not related to glfw and needs a bit more changes in justfile and workflows |
Contributor
|
Okay, let's do it another PR. Merging. |
gucio321
added a commit
to gucio321/cimgui-go
that referenced
this pull request
Dec 12, 2022
This reverts commit cc697fa.
eliasdaler
pushed a commit
that referenced
this pull request
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like @eliasdaler suggested, thirdparty/glfw should be a submodule like cimgui and cimplot
Upstream: https://github.com/glfw/glfw
Version/Revision: (current) master
fix #39