refactor(glfwbackend): move clear buffer before render loop #348
Conversation
anasrar
commented
Oct 11, 2024
anasrar
commented
- 08dd44f refactor(glfwbackend): move clear buffer before render loop: allow end user to use OpenGL before render ImGui
- c5bb738 refactor(glfwbackend): keep glfw context after window creation: allow end user to use OpenGL after window creation
|
Reference #325 |
|
|
||
| // Install extra callback | ||
| glfwSetWindowRefreshCallback(window, glfw_window_refresh_callback); | ||
| glfwMakeContextCurrent(NULL); |
There was a problem hiding this comment.
I think this is expected for multi window scenerio (?)
I think that you should keep this and use analogical method in your project and pass (*GLFWBackend).handle() (could make public if necessary)
There was a problem hiding this comment.
This one allow to call OpenGL function after creating window, like compile shader. This behaviour was valid in SDL backend. Otherwise you can only call OpenGL function on render loop or inside AfterCreateContext callback, since OpenGL function need glfwMakeContextCurrent to be set.
There was a problem hiding this comment.
hmm, ok so remove that line instead of commenting it out.
There was a problem hiding this comment.
@anasrar this causes
ERROR: ImGui_ImplOpenGL3_CreateDeviceObjects: failed to compile fragment shader! With GLSL: #version 130I'll revert.
There was a problem hiding this comment.
I've investigated a bit more to justify this:
it causes because giu uses mainthread to call Run() in mainthread.
possibly caused by the fact that CreateWindow might be called in another goroutine than Render loop
There was a problem hiding this comment.
@gucio321 sure, sorry for the inconvenience.
caused ERROR: ImGui_ImplOpenGL3_CreateDeviceObjects: failed to compile fragment shader! With GLSL: #version 130
hotfix(glfwbackend): revert part of #348
2 participants
