Skip to content

Comments #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AllenDang merged 14 commits into from
Apr 22, 2023
Merged

Comments #136

AllenDang merged 14 commits into from
Apr 22, 2023

Conversation

@gucio321
Copy link
Collaborator

@gucio321 gucio321 commented Apr 18, 2023

progress on #27

  • funcs
  • enum deffinitions

@gucio321
Copy link
Collaborator Author

gucio321 commented Apr 18, 2023

I think, I'll fix the whole #27 here as only struct comments left.

@gucio321 gucio321 marked this pull request as ready for review April 18, 2023 10:16
@gucio321
Copy link
Collaborator Author

gucio321 commented Apr 18, 2023

ok, done

@gucio321
Copy link
Collaborator Author

gucio321 commented Apr 18, 2023

oh wait, it needs generation i think

@gucio321 gucio321 marked this pull request as draft April 18, 2023 12:12
@gucio321
Copy link
Collaborator Author

gucio321 commented Apr 18, 2023

well it seems that I broke something...

@gucio321
Copy link
Collaborator Author

gucio321 commented Apr 18, 2023

ref: cimgui/cimgui#239

@gucio321
Copy link
Collaborator Author

gucio321 commented Apr 22, 2023

The issue is closed, so let me suppose this will work now

@gucio321 gucio321 marked this pull request as ready for review April 22, 2023 14:16
@gucio321
Copy link
Collaborator Author

gucio321 commented Apr 22, 2023

ok @AllenDang ready to review.

AllenDang
AllenDang approved these changes Apr 22, 2023
View reviewed changes
Copy link
Owner

@AllenDang AllenDang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@AllenDang AllenDang merged commit 12d6ead into AllenDang:main Apr 22, 2023
@gucio321 gucio321 deleted the comments branch April 22, 2023 16:33
@gucio321 gucio321 mentioned this pull request Apr 22, 2023
Closed
@gucio321 gucio321 linked an issue Apr 22, 2023 that may be closed by this pull request
Add comments to enums/structs/funcs etc. #27
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AllenDang AllenDang AllenDang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add comments to enums/structs/funcs etc.

2 participants

@gucio321 @AllenDang