Skip to content

Conversation

@gucio321
Copy link
Collaborator

@gucio321 gucio321 commented Apr 6, 2023

Intro

cimgui-go needs a simple way to update its dependencies (since it is a basic premise of the project).
This Pull Request introduces make update command.

Changelog

  • put all imgui dependencies in one folder (currently called cimgui)
  • change structure of imgui dependencies directory (now it consists of cimgui{_impl}.(h/cpp), imgui/ upstream and cimgui_templates with json defs)
  • use custom CMakeList.txt (this one in libs folder) which builds cimgui/cimplot shared library (note I think we might want to add glfw as well and combine everything in one shared lib)
  • update code

Issues and reference

updates cimgui only for now
@gucio321 gucio321 mentioned this pull request Apr 6, 2023
6 tasks
@gucio321 gucio321 force-pushed the cimgui-updater-v2 branch 2 times, most recently from 59c67ec to 689c114 Compare April 6, 2023 19:57
@gucio321 gucio321 force-pushed the cimgui-updater-v2 branch from 689c114 to 05c76a3 Compare April 6, 2023 19:58
@gucio321
Copy link
Collaborator Author

gucio321 commented Apr 7, 2023

it works now, finally!!!
Let it make it all together and it'll be ready!

@gucio321 gucio321 marked this pull request as ready for review April 7, 2023 13:12
@gucio321
Copy link
Collaborator Author

gucio321 commented Apr 7, 2023

@AllenDang, @eliasdaler if tests passes (I hope they will), this PR is ready to be reviewed!

@gucio321 gucio321 force-pushed the cimgui-updater-v2 branch from 21ba819 to 379c8e5 Compare April 7, 2023 13:57
Copy link
Owner

@AllenDang AllenDang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AllenDang AllenDang merged commit 4bd73a0 into AllenDang:main Apr 8, 2023
@gucio321 gucio321 deleted the cimgui-updater-v2 branch April 8, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants