[PWGEM] Other format for trigger normalization histos #12771
Conversation
rbailhac
requested review from
alibuild,
mikesas,
dsekihat,
ivorobye,
feisenhu and
hscheid
as code owners
|
O2 linter results: ❌ 14 errors, |
github-actions
bot
changed the title
| @@ -85,14 +100,14 @@ struct skimmerOTS { | |||
| if (mRunNumber == bc.runNumber()) { | |||
| return; | |||
| } | |||
|
|
|||
| zorro.setBaseCCDBPath(cfgCcdbPathZorro.value); | |||
There was a problem hiding this comment.
This is not needed anymore, because zorro objects have been moved to common directory.
| @@ -66,7 +76,12 @@ struct skimmerOTS { | |||
| hEventCounter->GetXaxis()->SetBinLabel(idx + 2, swt_names[idx].data()); | |||
| } | |||
|
|
|||
| registry.add("hNInspectedTVX", "N inspected TVX;run number;N_{TVX}", kTProfile, {{80000, 520000.5, 600000.5}}, true); | |||
| fStatsList.setObject(new TList()); | |||
There was a problem hiding this comment.
Can you move histograms under registry?
One can do following:
std::shared_pt h1; // as a data member;
h1 = registry.add("name", "title", kTH1D, {{your binning}}); // in init
zorro.populateExternalHists(XXXX, reinterpret_cast<TH1D*>h1, YYY)
There was a problem hiding this comment.
Hi Daiki, I am sorry but by me this solution did not compile. It was complaining about a impossible convertion of a std::shared_pt into reinterpret_cast<TH2D*>.
| @@ -66,7 +76,12 @@ struct skimmerOTS { | |||
| hEventCounter->GetXaxis()->SetBinLabel(idx + 2, swt_names[idx].data()); | |||
| } | |||
|
|
|||
| registry.add("hNInspectedTVX", "N inspected TVX;run number;N_{TVX}", kTProfile, {{80000, 520000.5, 600000.5}}, true); | |||
There was a problem hiding this comment.
can you keep hNInspectedTVX?
There was a problem hiding this comment.
The number of insptected TVX is in the zorro info histo, so that to avoid duplication of information I removed it.
|
Dear @rbailhac , Thank you for your PR. Please find my comments above. |
Use populateExternalHists