Skip to content

Conversation

@Miwoli
Copy link
Contributor

@Miwoli Miwoli commented Jul 19, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:
    Translation adjustment

What is the current behaviour? (You can also link to an open issue here)
Translation label for document viewer error was "Couldn't load preview. Unknown format."

What is the new behaviour?
Translation label for document viewer error is "Couldn't load preview. Unsupported file type or loading error. Please try refreshing the page."

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@Miwoli Miwoli force-pushed the HXCS-3181-Display-appropriate-error-if-rendition-polling-fails-on-document-viewer branch from b700fa9 to 9b13db5 Compare July 24, 2024 13:32
@montgolfiere
Copy link

montgolfiere commented Aug 7, 2024

@Miwoli do you need to also change the FE e2e at same time here ?

Or will the FE e2e need to be disabled until there is a separate follow-on PR ( cc @SoumyaHyland ) as per HXCS-4115 ?

I'm not sure whether it is possible to selectively disabled FE e2e for specific envs through the CD pipeline or do they always run with most recent "develop" 🤔 ?

See also my comment here

Another option here might be to change FE e2e to only check that error messages starts with Couldn't load preview 🤔 ? That way it will work before and after ( and can even be part of same PR as the text change ) ?

@Miwoli Miwoli force-pushed the HXCS-3181-Display-appropriate-error-if-rendition-polling-fails-on-document-viewer branch from 9b13db5 to 45422b6 Compare August 9, 2024 07:41
@Miwoli Miwoli force-pushed the HXCS-3181-Display-appropriate-error-if-rendition-polling-fails-on-document-viewer branch from 45422b6 to ad19487 Compare August 12, 2024 09:32
@sonarqubecloud
Copy link

@Miwoli Miwoli merged commit c3c84f7 into develop Aug 14, 2024
@Miwoli Miwoli deleted the HXCS-3181-Display-appropriate-error-if-rendition-polling-fails-on-document-viewer branch August 14, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants