AAE-38919 There is no deployment update without closing the panel #11263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures proper handling of WebSocket client re-initialization by creating a unique client for each user session and token refresh, and removing the client on logout. Addresses issues with deployment updates not being received due to incorrect client handling. This change ensures that the WebSocket connection is properly re-established when the user logs in again and when tokens are refreshed.
mkrbr
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
Replaces the `HttpClientTestingModule` import with `provideHttpClientTesting` to align with Angular's updated testing practices. This change ensures compatibility and avoids potential issues related to the deprecated module. Fixes AAE-38919
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes WebSocket authentication by making connection parameters dynamic, ensuring the authorization token is refreshed for each connection. This addresses AAE-38919, where deployment updates weren't working without closing the panel.
- Changed WebSocket connection parameters from static object to function for dynamic token retrieval
- Updated test imports to use newer Angular HTTP testing providers
- Reformatted constructor parameters for better readability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web-socket.service.ts | Made connectionParams dynamic function and improved constructor formatting |
| web-socket.service.spec.ts | Updated to use provideHttpClientTesting() instead of deprecated HttpClientTestingModule |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lib/process-services-cloud/src/lib/services/web-socket.service.spec.ts
Outdated
Show resolved
Hide resolved
….spec.ts Co-authored-by: Copilot <[email protected]>
|
JWollweber
approved these changes
Oct 16, 2025
mkrbr
deleted the
fix/AAE-38919-there-is-no-deployment-update-without-closing-the-panel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hyland.atlassian.net/browse/AAE-38919