AAE-38328 Support screens on start process event #11261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSekula
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
BSekula
commented
Oct 14, 2025
| } | ||
| private readonly destroyRef = inject(DestroyRef); | ||
|
|
||
| createDynamicComponent() { |
Contributor
Author
There was a problem hiding this comment.
This logic was moved to base screen
BSekula
force-pushed
the
feature/AAE-38328-support-screens-on-start-process-event
branch
from
c6ec3b6 to
c41a656
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for screens on start process events, expanding the existing functionality to handle screen-based start forms alongside traditional forms.
- Refactored task type detection into a dedicated service for better code reusability
- Created new screen components for start process events with base class architecture
- Extended start process component to handle screen types and their specific behaviors
Reviewed Changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
start-process-screen-mock.component.ts |
Mock component for testing start process screens |
user-task-cloud.component.ts |
Refactored to use new task type resolver service |
user-task-cloud.component.spec.ts |
Updated test setup for improved mock data handling |
task-type-resolver.service.ts |
New service to centralize task type detection logic |
task-type-resolver.service.spec.ts |
Comprehensive tests for task type resolution |
screen-cloud.component.ts |
Refactored to extend new base screen component |
start-process-screen.model.ts |
Interface definitions for start process screen components |
start-process-screen-cloud.component.ts |
New component for rendering start process screens |
start-process-screen-cloud.component.spec.ts |
Tests for the start process screen component |
start-process-screen-cloud.component.scss |
Styling for overlay screen display |
start-process-screen-cloud.component.html |
Template with conditional button rendering |
base-screen-cloud.component.ts |
Base class for screen components to reduce duplication |
start-process.component.mock.ts |
Enhanced mock helper for test flexibility |
start-process-cloud.component.ts |
Extended to support screen-based process starting |
start-process-cloud.component.spec.ts |
Added comprehensive tests for screen functionality |
start-process-cloud.component.html |
Template updated to render screens conditionally |
public-api.ts |
Updated exports for new screen components |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lib/process-services-cloud/src/lib/services/task-type-resolver/task-type-resolver.service.ts
Show resolved
Hide resolved
...n/components/screen-cloud/start-process-event-screen/start-process-screen-cloud.component.ts
Show resolved
Hide resolved
...components/screen-cloud/start-process-event-screen/start-process-screen-cloud.component.scss
Show resolved
Hide resolved
DudaRobert
approved these changes
Oct 14, 2025
tomaszhanaj
reviewed
Oct 14, 2025
| taskDetails: TaskDetailsCloudModel; | ||
| taskType: TaskTypesType; | ||
| taskTypeEnum = TaskTypes; | ||
| taskType: UserTaskType; |
Contributor
There was a problem hiding this comment.
I prefer to keep properties in alphabetical order, it helps to find properties.
tomaszhanaj
reviewed
Oct 14, 2025
| variables: this.variables ?? {} | ||
| }) | ||
| ); | ||
| let action: Observable<ProcessInstanceCloud>; |
Contributor
There was a problem hiding this comment.
thank you for replacing that completely unreadable ternary
|
tomaszhanaj
approved these changes
Oct 14, 2025
BSekula
deleted the
feature/AAE-38328-support-screens-on-start-process-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: