AAE-36368 Fixing labels and form-fields on content-ee and apa #10982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isoumyajit
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
Contributor
|
me and @MichalKinas we checked this PR and looks like styles are still incorrect in ACA: |
Isoumyajit
force-pushed
the
fix/AAE-36368-Multiple-styles-issues-for-metadata-sidebar
branch
from
46d614b to
71070a7
Compare
Isoumyajit
force-pushed
the
fix/AAE-36368-Multiple-styles-issues-for-metadata-sidebar
branch
from
71070a7 to
ec4956d
Compare
AleksanderSklorz
approved these changes
Jul 11, 2025
Contributor
AleksanderSklorz
left a comment
AleksanderSklorz
left a comment
There was a problem hiding this comment.
I'm approving it because it looks good for me but please wait for @dominikiwanekhyland approval too to ensure it works with his changes
Contributor
|
Hi, And this is after your changes: |
|
dominikiwanekhyland
approved these changes
Jul 11, 2025
DenysVuika
reviewed
Jul 11, 2025
| <div *ngSwitchCase="'autocompleteBased'"> | ||
| <mat-form-field | ||
| class="adf-property-field adf-card-selectitem-autocomplete" | ||
| class="adf-property-field adf-card-selectitem-autocomplete " |
DenysVuika
reviewed
Jul 11, 2025
| (click)="clicked()" | ||
| > | ||
| <mat-form-field class="adf-property-field adf-card-textitem-field" [floatLabel]="property.default ? 'always' : null"> | ||
| <mat-form-field class="adf-property-field adf-card-textitem-field " [floatLabel]="property.default ? 'always' : null"> |
DenysVuika
reviewed
Jul 11, 2025
|
|
||
| .adf-property-value-editable:not(:disabled) { | ||
| .adf-property-value-not-editable { | ||
| /* stylelint-disable-next-line declaration-no-important */ |
VitoAlbano
deleted the
fix/AAE-36368-Multiple-styles-issues-for-metadata-sidebar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://hyland.atlassian.net/browse/AAE-36368