[MNT-24459] Aspect list get all aspects when not all were fetched by first call #10980
Conversation
MichalKinas
requested review from
AleksanderSklorz,
dominikiwanekhyland,
g-jaskowski,
nikita-web-ua and
rmnvch
MichalKinas
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
lib/content-services/src/lib/aspect-list/services/aspect-list.service.spec.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/aspect-list/services/aspect-list.service.spec.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/aspect-list/services/aspect-list.service.spec.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/aspect-list/services/aspect-list.service.spec.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/aspect-list/services/aspect-list.service.spec.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/aspect-list/services/aspect-list.service.spec.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/aspect-list/services/aspect-list.service.spec.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/aspect-list/services/aspect-list.service.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/aspect-list/services/aspect-list.service.ts
Outdated
Show resolved
Hide resolved
|
|
||
| getCustomAspects(whiteList?: string[]): Observable<AspectEntry[]> { | ||
| getCustomAspects(whiteList?: string[], paginationOptions?: ContentPagingQuery): Observable<AspectPaging> { | ||
| const where = `(not namespaceUri matches('http://www.alfresco.*'))`; |
There was a problem hiding this comment.
That function almost completely duplicates previous function. Can we avoid duplications? Basically everything except 'where' seems the same. We can move everything except where to reusable private function OR we can pass where as parameter and then we will have only one function.
Maybe second option has more sense because do we really need 2 separate functions just to separate custom and standards aspects if both load the same (aspects)? So we can specify just by parameter which aspects should be loaded. In that case I think we may need to introduce one more type for Where to avoid creating that complicated string on consumer side - consumer can just specify fields in that Where parameter and then 'where' string can be built inside function based on these parameters
There was a problem hiding this comment.
Refactored, it should look better now
|
MichalKinas
deleted the
bugfix/dev-mkinas-MNT-24459-adw-edit-aspects-returns-maximum-100-aspects
branch
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/MNT-24459
What is the new behaviour?
Now when there are still more aspects to be loaded, they will be fetched until all are loaded as user should have the access to all visible aspects.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: